[SSSD] [PATCHES] Patches for Coverity issues in ding-libs INI

Stephen Gallagher sgallagh at redhat.com
Mon Jan 3 19:03:10 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/24/2010 04:45 PM, Dmitri Pal wrote:
> Hello,
> 
> 	
> 10034
> 	
> Patch attached
>  
> 10041
> 	
> No patch. It is currently fixed on master and on 0.1.x the code is not used.
> This issue should be dismissed.
> 	
> 10042
> 	
> No patch. It is currently fixed on master and on 0.1.x the code is not used.
> This issue should be dismissed.
> 
> 	
> 10044
> 	
> Patch attached
> 
> 	
> 10048
> 	
> Patch attached. Patch was developed on master but since this code has not changed for a long time
> the patch should also apply to the 0.1.x branch. The patch name is "COLLECTION-Initializing-variables-in-test". 
> 	
> 10071
> 	
> Patch attached.
> 	
> 10072
> 	
> Patch attached.
>  
> 10073
> 	
> Patch attached.	
> 	
> 10076
> 	
> Patch attached.
>  
> 10077
> 	
> Patch attached.
> 
> 
> Also there is an attempt to sort out issues 10078 - 10079. See patch
> comments.
> 
> 
> 
> The only remaining Coverity issue is:
> 
> 10075
> 	
> I want to redo the way we deal with paths to config files across the whole test.
> Stay tuned for the patch.



Patches 0001-0007: Ack

Patch 0008: Nack.

I think a more sensible approach here would be to nullify 'vo' after
freeing it. This will guarantee that you won't accidentally try to
continue using that data (since it would dereference NULL and cause a
segfault) but if there's another situation that Coverity would detect
where we WOULD be reusing that memory, it will be easier to identify
(since it will not be NULL there instead of a random memory location)


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0iHW4ACgkQeiVVYja6o6OWpgCghK7mNKWZ5pxOP4S8VHTjeJ4q
TrkAoKa97ALS9lIShFbBvEQ7MeO3sXD8
=LhXB
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list