[SSSD] [PATCH] Verify LDAP file descriptor validity

Stephen Gallagher sgallagh at redhat.com
Mon Feb 14 15:15:39 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

We weren't verifying that the file descriptor that we get back from
openldap was valid. This patch checks that the file descriptor is >= 0
before returning it.

There's another (arguable) bug here in libtevent. Libtevent should
probably not return success for tevent_add_fd() when fd < 0 (especially
since it crashes). I'll open a bug upstream.


Fixes https://fedorahosted.org/sssd/ticket/797 and
https://bugzilla.redhat.com/show_bug.cgi?id=676027

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk1ZRxsACgkQeiVVYja6o6N9HQCcCas4ORYpjW9PiHAvSn0Avba/
5dYAoJOPVfWzVGB7KoZTq9uPNrEXBi7d
=kWO0
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Verify-LDAP-file-descriptor-validity.patch
Type: text/x-patch
Size: 896 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110214/386e91d8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Verify-LDAP-file-descriptor-validity.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110214/386e91d8/attachment.sig>


More information about the sssd-devel mailing list