[SSSD] [PATCHES] sss_obfuscate fixes

Stephen Gallagher sgallagh at redhat.com
Wed Feb 2 16:22:12 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/02/2011 04:23 AM, Sumit Bose wrote:
> On Tue, Feb 01, 2011 at 04:18:27PM -0500, Stephen Gallagher wrote:
> Patch 0001: Make the domain argument mandatory in sss_obfuscate
> It doesn't make sense to set a "default" domain. We should require
> that the domain always be specified.
> 
>> ACK
> 
> 
> Patch 0002: Gracefully handle permission errors in sss_obfuscate
> Don't show a traceback if not run as root.
> Replaces patch from "Fixing traceback call messages for sss_obfuscate
> command"
> 
>> Just some nitpicking:
> 
>> - SSSDConfig.SSSDConfig() only throws an IOError if it cannot read the
>>   schema files. If there is a setup where this really happens then I
>>   think "Permission denied when reading current configuration" is
>>   misleading, because changing the permissions on sssd.conf wouldn't
>>   help.
>> - Not related to this patch, but maybe you want to fix this too. If
>>   there is no config file name given on the command line
>>   options.filename is empty and if SSSDConfig.import_config cannot read
>>   the default config file the message "Cannot open config file None" is
>>   printed.
>> - Even less related, but still important. -p is broken, it takes the
>>   codepath of -s so you have to press CTRL-D to leave sss_obfuscate but
>>   even then the value of -p is not taken, but the empty string is
>>   obfuscated. If would vote to remove this option, because it can easy
>>   be substituted by 'echo -n password | sss_obfuscate -d domain -s'

All good suggestions. I didn't address -p, as Gowrishankar has submitted
a patch to address this.

I've updated my patches accordingly, and added a third patch that makes
the SSSDConfig API internal configuration files world-readable.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk1JhLQACgkQeiVVYja6o6PmCACfQoGWKAQ0SPu3caZ3to7YKlI1
YpMAnR4eUHr5R+/WjDRlm3jxddaHDKeE
=G4/K
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-the-domain-argument-mandatory-in-sss_obfuscate.patch
Type: text/x-patch
Size: 1646 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110202/7684e1c4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Gracefully-handle-permission-errors-in-sss_obfuscate.patch
Type: text/x-patch
Size: 1591 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110202/7684e1c4/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Make-SSSDConfig-API-configuration-readable.patch
Type: text/x-patch
Size: 2090 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110202/7684e1c4/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-the-domain-argument-mandatory-in-sss_obfuscate.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110202/7684e1c4/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Gracefully-handle-permission-errors-in-sss_obfuscate.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110202/7684e1c4/attachment-0001.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Make-SSSDConfig-API-configuration-readable.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110202/7684e1c4/attachment-0002.sig>


More information about the sssd-devel mailing list