[SSSD] [PATCHES] Fix two simple Coverity issues
Stephen Gallagher
sgallagh at redhat.com
Mon Dec 19 15:07:20 UTC 2011
On Mon, 2011-12-19 at 09:27 +0100, Jan Zelený wrote:
> > Patch 0001: Guarantee NULL-termination when reading the pidfile
>
> I think it would be better to use
>
> pid_str[len] = '\0';
>
> instead of
>
> pid_str[pidlen] = '\0';
Good idea. Fixed.
>
> > Patch 0002: Always set umask when using mkstemp()
>
> For the record, this does fix 12397 and not 12398 as it is claimed in the
> patch. Would you please also include 12396 and 12398 to this patch?
Done.
Thanks for the review. New patches attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Reorder-pidfile-function-to-guarantee-NULL-terminati.patch
Type: text/x-patch
Size: 1115 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111219/af493f78/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Securely-set-umask-when-using-mkstemp.patch
Type: text/x-patch
Size: 4028 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111219/af493f78/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111219/af493f78/attachment.sig>
More information about the sssd-devel
mailing list