[SSSD] [PATCH] Ability to set a domain as case sensitive or insensitive

Stephen Gallagher sgallagh at redhat.com
Tue Dec 13 18:41:12 UTC 2011


On Tue, 2011-12-13 at 14:44 +0100, Jakub Hrozek wrote:

Patch 0001: Nack
I don't like that we're assuming the length of the string here. I'd much
prefer that sss_utf8_tolower() and sss_tc_utf8_tolower() take a length
argument and pass those verbatim to the libunistring and glib2
lowercasing functions. We shouldn't assume that the string is
NULL-terminated (and it's possible, though unlikely, that we might at
some point want to work on a substring anyway).

Also, I don't think it's safe to use talloc_strdup() in
sss_tc_utf8_tolower(). It would be safer here to use talloc_memdup().


Patch 0002: Ack.

Patch 0003: Nack
Correct me if I'm wrong, but aren't you leaking the old pd->user if you
replace it with the primary name?

Patch 0004: Ack

Patch 0005: Ack

Patch 0006: Ack

Patch 0007: Ack

patch 0008: This should probably be using sss_utf8_case_eq() instead of
strcasecmp().

Patch 0009: Ack.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111213/4380468c/attachment.sig>


More information about the sssd-devel mailing list