[SSSD] [PATCH] Allow using Glib for UTF8 support

Simo Sorce ssorce at redhat.com
Fri Dec 2 20:16:01 UTC 2011


----- Original Message -----
> Currently, SSSD only supports using libunistring to manage unicode
> strings. There are some platforms out there (such as RHEL 5) that do
> not
> have libunistring available. With this patch, we add an optional flag
> to
> autoconf to allow SSSD to link against Glib and use its unicode
> functionality.

Two quick comments.
1. Can you use a shorter function name than sss_utf8_case_insensitive_equality ?
I am all for clarity, but when the function name is so long arguments go on the next line w/o any nesting it is bad :-)

2. given result returns just a boolean I would prefer to not use it and just use ret.
0 is 'matches' and some other error code means it didn't match, something like ERANGE could be used. or if you feel strongly about having your own value define a value like -1 as ENOMATCH earlier in the code. It makes for a more usable interface if you do not have to care about 2 return variables IMO.

Simo.



More information about the sssd-devel mailing list