[SSSD] [PATCH] new tool - sss_debuglevel
Jakub Hrozek
jhrozek at redhat.com
Mon Aug 22 11:46:46 UTC 2011
On Tue, Aug 16, 2011 at 02:35:42PM +0200, Pavel Březina wrote:
> sss_debuglevel - change the debug level on the fly
>
> https://fedorahosted.org/sssd/ticket/950
>
> Requires "New DEBUG facility" patches.
> +errno_t set_debug_level(
> + struct debuglevel_tool_ctx *tool_ctx, int debug_to_set,
> + const char *config_file
> +)
> +{
> + int ret;
> + int err;
> + const char *values[2];
> + char **section = NULL;
> + TALLOC_CTX *ctx = talloc_new(NULL);
> +
Please name temporary context tmp_ctx so it is immediatelly clear that it
is a just a temporary one.
My only other comment is that I don't really like the style of the function
definitions, but that's just a subjective thing.
I would appreciate a review from somebody else as I saw and commented on
the patche before they went to the list (and it was the last to be done
this way, time to take the training wheels off :-))
More information about the sssd-devel
mailing list