[SSSD] [PATCH 029-032] Refactoring of sdap_async_accounts

Stephen Gallagher sgallagh at redhat.com
Mon Aug 15 13:17:39 UTC 2011


On Mon, 2011-08-15 at 15:00 +0200, Jan Zelený wrote:
> > > > So here it is, a set of patches splitting file sdap_async_accounts and
> > > > making some subsequent changes. If anyone has other ideas what could be
> > > > changed, let me know.
> > > > 
> > > > I was in favor of splitting the file into 3, as Simo suggested:
> > > > sdap_async_users.c
> > > > sdap_async_groups.c
> > > > sdap_async_initgroups.c
> > > > 
> > > > This way three basic operations are separated, but they are not
> > > > separated too much (otherwise a _common.c file would have to be
> > > > present, since some routines are shared by code paths in different
> > > > schemas).
> > > > 
> > > > 
> > > > Thanks
> > > > Jan
> > > 
> > > Stephen,
> > > I rebased the patches as we discussed and I'm sending them for another
> > > round of review.
> > > 
> > > Just to remind you: last time on IRC (also in the mail) you had the
> > > objection that the initgroups operation handling should be split in three
> > > files (no other file contains three entirely different code paths for
> > > different schemas). I opposed you that those three parts are in one file,
> > > but they are now well separated (they are divided by comment lines, I can
> > > make them more visible if you wish).
> > > 
> > > I'd like to hear your opinion if this approach is ok or you insist on
> > > splitting the file to three.
> > > 
> > > 
> > > Thanks
> > > Jan
> > 
> > These are rebased on top of my previous sysdb refactoring patches.
> > 
> > Jan
> 
> Bug-free version now
> 
> Jan

Ack and pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110815/2839af0e/attachment.sig>


More information about the sssd-devel mailing list