[SSSD] [PATCH] Allow more libldap debugging

Jan Zelený jzeleny at redhat.com
Wed Aug 10 13:29:50 UTC 2011


> On Wed, Aug 10, 2011 at 10:14:14AM +0200, Jan Zelený wrote:
> > > This patch should not be pushed to master, but I would like to get it
> > > reviewed anyway.
> > > 
> > > It should be used to provide a custom build for users experiencing
> > > cases where ldap_search_ext would block (c.f.
> > > https://bugzilla.redhat.com/show_bug.cgi?id=728343)
> > > 
> > > For example:
> > > export SSSD_DEBUG_LDAP_SEARCH="0xffff"
> > > would set LDAP_DEBUG_ANY
> > > 
> > > The attached patch applies cleanly on the RHEL6.1 branch. I also have a
> > > version that applies on master/1.5 if needed.
> > 
> > I have three things:
> > On line 98 you close the original stderr - this is not a problem, but it
> > is redundant
> > 
> > On line 162 you are using strtol and testing that it did not fail. Please
> > consider two possibilities that you haven't considered in your patch:
> > - the function did not fail, but non-zero value remains in errno from
> > previous program run
> > - the env. variable SSSD_DEBUG_LDAP_SEARCH contains empty string (I'm not
> > sure whether it is possible)
> > 
> > Other than that the patch looks fine.
> > 
> > Jan
> 
> Thanks, a new patch is attached.

Looks ok now,
Ack

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110810/adcc6b51/attachment.sig>


More information about the sssd-devel mailing list