[SSSD] [PATCH] Memberof plugin rewritten
Simo Sorce
simo at redhat.com
Thu Aug 4 11:58:10 UTC 2011
On Wed, 2011-08-03 at 15:40 +0200, Jan Zelený wrote:
> Hi,
> after several weeks of work and couple failed concepts, I'm sending rewritten
> memberof plugin with reference counter support. For now I'm just interested in
> concept ack, since the plugin has still some heisenbugs and isn't stable at
> all.
>
> The recompute task also isn't ready, I don't want to do it before I have the
> concept acked and the rest of plugin stable.
>
> Many thanks in advance for any kind of review
>
Jan one thing I see is that you removed the detailed comments about each
function operated and replaced them with nothing. Those comments are
fundamental to give a clue about how things are supposed to work.
I think w/o detail comments that explain how the function are supposed
to work (ie the logic behind them) I will NACK any change.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
More information about the sssd-devel
mailing list