[SSSD] [PATCHES] Add support for paged LDAP results

Stephen Gallagher sgallagh at redhat.com
Mon Apr 25 19:33:37 UTC 2011


On Mon, 2011-04-25 at 14:26 -0400, Stephen Gallagher wrote:
> Patch 0001: Added a debug message to see which record type we're
> processing on each loop through sdap_process_message(). This is purely
> informational.
> 
> Patch 0002: Add support for paged LDAP results.
> I changed the internals of sdap_get_generic_send() somewhat here and
> added a new sdap_get_generic_internal() routine that can be used to
> handle multiple calls to LDAP for a single request. We should be able to
> use this in the future to handle Active Directory's non-standard
> attribute-level paging as well (though that's not addressed in this
> patch).
> 
> Patch 0003: Add ldap_page_size configuration option
> I made this a separate patch for simplicity of review. I set 1000
> records as the default, as this seemed to be the most-compatible value
> among 389, OpenLDAP and ActiveDirectory as best I could determine.


Simo made some comments on IRC that I have incorporated.

First, I renamed sdap_get_generic_send_internal() to
sdap_get_generic_step() and reordered it according to the tevent_req
style. Second, I added talloc_zfree(state->op) to the beginning of
sdap_get_generic_step() to ensure that we aren't carrying around extra
sdap_op memory for subsequent pages.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Log-the-LDAP-message-type-we-re-processing.patch
Type: text/x-patch
Size: 2516 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110425/1bbc6b9a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Enable-paging-support-for-LDAP.patch
Type: text/x-patch
Size: 8129 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110425/1bbc6b9a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-ldap_page_size-configuration-option.patch
Type: text/x-patch
Size: 7749 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110425/1bbc6b9a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110425/1bbc6b9a/attachment.sig>


More information about the sssd-devel mailing list