[SSSD] [PATCH] Select principal for GSSAPI authentication

Stephen Gallagher sgallagh at redhat.com
Mon Apr 25 12:04:50 UTC 2011


On Thu, 2011-04-21 at 14:13 +0200, Jan Zelený wrote:
> > On Thu, 2011-04-21 at 12:30 +0200, Jan Zelený wrote:
> > > > Nack.
> > > > 
> > > > You still have unchecked talloc_strdup() calls in this patch in
> > > > select_principal_from_keytab().
> > > 
> > > I don't think so, all talloc_strdup() calls in that function are checked
> > > for NULL output. But there was a tiny glitch, which is fixed in attached
> > > patch.
> > > 
> > > Jan
> > 
> > Sorry, I wrote talloc_strdup() and really meant talloc_asprintf(). Mea
> > culpa.
> 
> Ah, that explains why I didn't find it, I looked at the output part of the 
> function. Thanks for clarifying.
> 
> > Could you please elaborate on the "tiny glitch" as well?
> 
> Nothing serious, I just added code which frees already allocated outputs if 
> one of them fails.


Ack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110425/2deed638/attachment.sig>


More information about the sssd-devel mailing list