[SSSD] [PATCH] Read only rootDSE data if rootDSE is available

Sumit Bose sbose at redhat.com
Fri Apr 8 11:32:47 UTC 2011


and now with patch :-)
On Fri, Apr 08, 2011 at 01:30:44PM +0200, Sumit Bose wrote:
> Hi,
> 
> shanks found an issue if the rootDSE is not available. This patch should
> fix it.
> 
> bye,
> Sumit
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel
-------------- next part --------------
From 9b7c729b55d7ff0d8b9ebc131b51fced51519a8e Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Fri, 8 Apr 2011 13:27:47 +0200
Subject: [PATCH] Read only rootDSE data if rootDSE is available

---
 src/providers/ldap/sdap_async_connection.c |   42 ++++++++++++++-------------
 1 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/src/providers/ldap/sdap_async_connection.c b/src/providers/ldap/sdap_async_connection.c
index d2eadfa..fbbb444 100644
--- a/src/providers/ldap/sdap_async_connection.c
+++ b/src/providers/ldap/sdap_async_connection.c
@@ -1269,28 +1269,30 @@ static void sdap_cli_rootdse_done(struct tevent_req *subreq)
         }
     }
 
-    /* save rootdse data about supported features */
-    ret = sdap_set_rootdse_supported_lists(rootdse, state->sh);
-    if (ret) {
-        tevent_req_error(req, ret);
-        return;
-    }
+    if (state->use_rootdse) {
+        /* save rootdse data about supported features */
+        ret = sdap_set_rootdse_supported_lists(rootdse, state->sh);
+        if (ret) {
+            tevent_req_error(req, ret);
+            return;
+        }
 
-    ret = sdap_set_config_options_with_rootdse(rootdse, state->sh,
-                                               state->opts);
-    if (ret) {
-        DEBUG(1, ("sdap_set_config_options_with_rootdse failed.\n"));
-        tevent_req_error(req, ret);
-        return;
-    }
+        ret = sdap_set_config_options_with_rootdse(rootdse, state->sh,
+                                                   state->opts);
+        if (ret) {
+            DEBUG(1, ("sdap_set_config_options_with_rootdse failed.\n"));
+            tevent_req_error(req, ret);
+            return;
+        }
 
-    ret = sdap_get_server_opts_from_rootdse(state,
-                                            state->service->uri, rootdse,
-                                            state->opts, &state->srv_opts);
-    if (ret) {
-        DEBUG(1, ("sdap_get_server_opts_from_rootdse failed.\n"));
-        tevent_req_error(req, ret);
-        return;
+        ret = sdap_get_server_opts_from_rootdse(state,
+                                                state->service->uri, rootdse,
+                                                state->opts, &state->srv_opts);
+        if (ret) {
+            DEBUG(1, ("sdap_get_server_opts_from_rootdse failed.\n"));
+            tevent_req_error(req, ret);
+            return;
+        }
     }
 
     sasl_mech = dp_opt_get_string(state->opts->basic, SDAP_SASL_MECH);
-- 
1.7.4.2



More information about the sssd-devel mailing list