[SSSD] [PATCH] Add user and group search LDAP filter options

Jan Zelený jzeleny at redhat.com
Wed Apr 6 06:58:59 UTC 2011


Jakub Hrozek <jhrozek at redhat.com> wrote:
> On Tue, Apr 05, 2011 at 03:43:46PM +0200, Jan Zelený wrote:
> > Jakub Hrozek <jhrozek at redhat.com> wrote:
> > > I have a couple of smaller patches in the backlog from when I had a
> > > spare moment here and there but not enough to dive into a big feature.
> > > 
> > > https://fedorahosted.org/sssd/ticket/647
> > 
> > I have two small comments:
> > 
> > 1. I think the function get_id_specific_filter() should have a prefix
> > sdap_ 2. Please move the talloc_zfree() calls on lines 87 and 130 of the
> > patch before respective if() statements.
> > 
> > And one thought/question: shouldn't there be some kind of check of the
> > orig_filter == NULL in get_id_specific_filter() function? Just in case
> > something goes wrong. I know that at current code this situation can
> > never happen, but as a precaution. At least something like
> > 
> > if (!orig_filter) return NULL;
> > 
> > Other than that the patch is ok.
> > 
> > Jan
> > _______________________________________________
> 
> Thanks, review comments factored in, new patch attached.

Ack

Jan



More information about the sssd-devel mailing list