[SSSD] [PATCHES] Support for netgroups in the NSS client and responder

Stephen Gallagher sgallagh at redhat.com
Thu Sep 23 15:04:00 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/22/2010 07:28 PM, Stephen Gallagher wrote:
> 
> Patch 0006: Rename group.c and passwd.c for clarity
> Prefixing group.c and passwd.c with "nss_" similar to the way the
> PAM client sources are prefixed with "pam_". This patch isn't strictly
> necessary, but I wanted it to be more clear which files were associated
> with NSS vs. PAM vs. common in the sss_client directory. Patch 0007 will
> create nss_netgroup.c as well.

Forgot to update POTFILES.in with the new names.


> 
> Patch 0007: Add support for netgroups to NSS sss_client
> There's one peculiarity about this patch that I have to note. I need to
> send back a true/false value to the setnetgrent call in order to
> properly report that there were no entries. This differs from the other
> set*ent functions because we are processing a specific requested entry
> rather than enumerating all entries. Without doing this, we actually
> return a netgroup containing no member triples, which is certainly not
> what the client app expects.


Drop a #include on a header that isn't packaged (and should probably be
removed in a separate patch). It caused builds from a tarball to fail.

> Patch 0010: Add netgroup support to the NSS responder
> This is the big one. It borrows a lot of its design from the recently
> rewritten enumeration code, but it has a few gotchas (notably that we
> need to maintain state between setnetgrent and getnetgrent calls to
> ensure that we are still answering requests for the same requested entry.
> 

Missed including nsssrv_private.h and nsssrv_netgroup.h from the
dist_noinst_HEADERS in Makefile.am.  Builds from a tarball were failing.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkybbGAACgkQeiVVYja6o6NK8gCfcPg2YSio/kVHv5otv44SoiQa
CsgAn38LKEywSlBFC06uiR71RwJrhs2p
=ZJha
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Rename-group.c-and-passwd.c-for-clarity.patch
Type: text/x-patch
Size: 2138 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100923/79c34902/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Add-support-for-netgroups-to-NSS-sss_client.patch
Type: text/x-patch
Size: 13146 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100923/79c34902/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Add-netgroup-support-to-the-NSS-responder.patch
Type: text/x-patch
Size: 35731 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100923/79c34902/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Rename-group.c-and-passwd.c-for-clarity.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100923/79c34902/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Add-support-for-netgroups-to-NSS-sss_client.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100923/79c34902/attachment-0001.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Add-netgroup-support-to-the-NSS-responder.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100923/79c34902/attachment-0002.sig>


More information about the sssd-devel mailing list