[SSSD] [PATCH][ding-libs] Build all of the ding-libs from the root

Stephen Gallagher sgallagh at redhat.com
Wed Sep 22 18:13:17 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/22/2010 07:20 AM, Stephen Gallagher wrote:
> On 09/22/2010 04:04 AM, Sumit Bose wrote:
>>> - I think a toplevel m4 directory is missing and all m4 directories from
>>> the subdirectories can be removed.
> 
> Whoops, you're right. I missed that. Fixed.
> 
>>> - The README file needs an update to reflect the changes.
> 
> Fixed.
> 
>>> - there is an empty last line in version.m4
> 
> That's intentional. I never trust that any parser handles EOF gracefully
> (because so many forget to)
> 
>>> With the m4 directory changes I was able to run 'make distcheck', 'make
>>> rpms' and friends without any issue.
> 
> 
> I also made a few additional changes that struck me while I was fixing
> the above.
> 
> I noticed that I was packaging the wrong README file in %doc in dhash,
> and I wasn't packaging the README for either ref_array or path_utils.
> 
> I changed the names of those files to README.dhash, etc. so that when
> running 'make install' they would not overwrite each other. (Before,
> when they were separate tarballs they would have been placed in a
> different path)
> 
> 
> New patch attached. Thank you for the review.
> 

Dmitri noticed that we weren't generating the docs correctly. The
attached patch addresses this.


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyaRz0ACgkQeiVVYja6o6O1NQCcDn+cJm8bdE+RVGpG5mDFI8z6
0gkAoI0Hl8q5DnfERFz+GKCQo/rVZ1XI
=76Cc
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Build-all-of-the-ding-libs-from-the-root.patch.gz
Type: application/x-gzip
Size: 70814 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100922/6879679a/attachment.gz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Build-all-of-the-ding-libs-from-the-root.patch.gz.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100922/6879679a/attachment.sig>


More information about the sssd-devel mailing list