[SSSD] [PATCHES] Sysdb interface for netgroups

Stephen Gallagher sgallagh at redhat.com
Mon Sep 20 17:14:58 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/20/2010 06:46 AM, Sumit Bose wrote:

>> The patches apply fine. There is a whitespace issue, 0001 adds an empty
>> line at the end of sysdb_search.c . All tests passed, please find some
>> comments below.

Fixed.

> ret is undefined

Good catch. Fixed.


> I think it would better match with the other functions to have a 'done'
> block which is also called if ret==EOK.

Agreed. Fixed.


> talloc_strndup might be more convenient here

I completely forgot about this function. Thanks!



> I think a missing closing parenthesis should be an error.

Yeah, I missed that. Fixed.

> I think it would be safer to use talloc_strndup with el->values[j].length

Agreed. Fixed.



As mentioned in my other email, I've also split sysdb_getnetgr() into
two functions. sysdb_getnetgr() will return the ldb_result as retrieved
from the database, and sysdb_netgr_to_triples() which will convert that
result into a list of triples. The tests have been updated accordingly.

The add/remove aliases are mostly there in case we discover that we need
to diverge in how we handle them. Jan, if you really want me to yank
them, I can.



- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyXlpIACgkQeiVVYja6o6OMbQCglobBjIn2P2geIfqXbuRKdWWy
L78AnRSQ4uAjKyh/5/QOEd5cQ9CmwVWx
=kVk5
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list