[SSSD] [PATCHES] Sysdb interface for netgroups

Stephen Gallagher sgallagh at redhat.com
Fri Sep 17 15:21:40 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/17/2010 11:16 AM, Dmitri Pal wrote:
> Stephen Gallagher wrote:
>> On 09/16/2010 05:05 PM, Stephen Gallagher wrote:
>>> I've rewritten these patches. Now, instead of searching for individual
>>> netgroup entries, the code will take advantage of the memberOf plugin to
>>> return all netgroup triples in a single call to sysdb_getnetgr()
>>
>>> This approach will make life easier with LDAP as well, as we will have
>>> built-in loop prevention.
>>
>>> Please review these patches while my netgroup work is ongoing.
>>
>>> Patch 0001: New sysdb interfaces for netgroups. Add and delete support
>>> for netgroups entries, tuples and nested netgroups.
>>
>>> Patch 0002: Unit tests for the above interfaces.
>>
>>
>>
>> Yet another change to these patches.
>>
>> I realized that I actually need to get back the three strings from the
>> triple instead of the internal representation. It makes the most sense
>> for this to be done in sysdb_getnetgr(), so attached are two new patches
>> which changes the interface (again) to return a structure of three
>> strings instead of a single string representing the tuple.
>>
>>
> Stephen, I just glanced over. Did not have a thorough review.
> There is a bug in sysdb_netgr_split_triple
> The user, host and domain strings need to be initialized to NULL.
> 
> Have not looked at other places :)
> 

Ah, you're correct. I accidentally initialized the wrong pointers (the
p_* pointers). Thanks for that. New patch attached.


This is what I get for not writing exhaustive unit tests, but I'm
working on a deadline here :)

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyTh4QACgkQeiVVYja6o6N1DwCeItdwGQoqPStrHs76nbzmHAIc
IyoAn3kLMRSzopQeJevNMD4RbrJpHmha
=IvTL
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Netgroups-sysdb-API.patch
Type: text/x-patch
Size: 31106 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100917/61f99e72/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-netgroup-tests.patch
Type: text/x-patch
Size: 17143 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100917/61f99e72/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Netgroups-sysdb-API.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100917/61f99e72/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-netgroup-tests.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100917/61f99e72/attachment-0001.sig>


More information about the sssd-devel mailing list