[SSSD] [PATCHES] Fix two serious issues with initgroups

Stephen Gallagher sgallagh at redhat.com
Tue Sep 14 12:07:47 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/13/2010 04:36 PM, Simo Sorce wrote:
> On Mon, 13 Sep 2010 15:43:33 -0400
> Stephen Gallagher <sgallagh at redhat.com> wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 09/13/2010 03:41 PM, Simo Sorce wrote:
>>> On Mon, 13 Sep 2010 15:09:28 -0400
>>> Stephen Gallagher <sgallagh at redhat.com> wrote:
>>>
>>>> Sorry, noticed a tiny oversight on patch 0001. I had only fixed the
>>>> DEBUG message for the add case, and missed the del case. The new
>>>> patch 0001 corrects this.
>>>>
>>>
>>> Aren't those bugs a separate issue worth their own patch ?
>>> (there is also no mention of this issue in the commit message
>>> AFAICS)
>>>
>>> Simo.
>>>
>>
>> I can split them out. I only included them because I needed to fix
>> them to help identify the real problem.
> 
> They are a potential crash bug, so it would be better if we separated
> them as they are a fix on their own.
> 
> If you split them you get as bonus an automatic ack for all three :)
> 
> Simo.
> 

Split and attached for posterity. Thanks for the review.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyPZZMACgkQeiVVYja6o6PbKACfc31Om0Z5fAz11kyb9gjtwMjC
FrwAoI1YFW2JiGdmpKF45GQKc2wgBvOr
=p6um
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Request-all-group-attributes-during-initgroups-proce.patch
Type: text/x-patch
Size: 2259 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100914/c8b9cb60/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-missing-variable-substitution-in-DEBUG-message.patch
Type: text/x-patch
Size: 1420 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100914/c8b9cb60/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Initgroups-on-a-non-cached-user-should-go-to-the-dat.patch
Type: text/x-patch
Size: 2084 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100914/c8b9cb60/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Request-all-group-attributes-during-initgroups-proce.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100914/c8b9cb60/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-missing-variable-substitution-in-DEBUG-message.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100914/c8b9cb60/attachment-0001.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Initgroups-on-a-non-cached-user-should-go-to-the-dat.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100914/c8b9cb60/attachment-0002.sig>


More information about the sssd-devel mailing list