[SSSD] [PATCH] Minor fixes in various places

Stephen Gallagher sgallagh at redhat.com
Thu Sep 2 16:18:31 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/31/2010 07:56 AM, Jan Zelený wrote:
> Stephen Gallagher <sgallagh at redhat.com> wrote:
>> On 08/31/2010 07:39 AM, Jan Zelený wrote:
>>> Stephen Gallagher <sgallagh at redhat.com> wrote:
>>>>>> 0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch
>>>>>> Ticket: #579
>>>>>
>>>>> Provided that it is safe to pass a NULL pointer to fprintf(), this is
>>>>> OK. I know that glibc handles this, but I'm not entirely sure if that
>>>>> it is good behaviour (if this would work with all possible
>>>>> optimalizations) and if other libc implementations behave the same as
>>>>> glibc.
>>>>
>>>> This is a bug in e.g. the Intel compiler, if I remember correctly.
>>>> Please fix fprintf. I recommend using the construct:
>>>> name ? name : "";
>>>> in the fprintf call.
>>>
>>> Wouldn't it be better just to initialize the variable with "" then?
>>
>> Jakub mentioned off-list that we should probably fix this in the DEBUG()
>> macro, rather than trying to guard against it in each possible use-case.
>> I think I agree with him.
> 
> Yes, that's probably a good idea. Is the patch ACKed in that case?


Yes. Ack.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkx/zlcACgkQeiVVYja6o6N7MgCfV8IcE/OIT0GLEGGNVEAtg/JC
H/MAn2Qr7WlnSvJd1/dDGCrFFXMewR8X
=xqe+
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list