[SSSD] [PATCH] Minor fixes in various places

Stephen Gallagher sgallagh at redhat.com
Thu Sep 2 14:04:42 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/01/2010 05:56 AM, Jan Zelený wrote:
> 
> Both your points are valid. I'm attaching a patch where the check is 
> performed. I still think it is redundant, but it might be more safe in the 
> future in case the code around it changes.


Nack.

This line:
dp_error = DP_ERR_FATAL;
is completely unnecessary. dp_error is never read again after this
assignment.

I realize that it was there before this patch, but it's unnecessary and
wrong. Please remove it.

The rest of the patch looks good.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkx/rvkACgkQeiVVYja6o6MipQCfdl27dqBq1xN42AWoJmaTs0bJ
QWgAn2yN/ZF7LkOgvLzy9myYunC2sK9x
=QtVl
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list