[SSSD] [PATCH] Always use uint32_t for UID/GID numbers (master)
Stephen Gallagher
sgallagh at redhat.com
Tue Oct 26 12:04:59 UTC 2010
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/26/2010 07:42 AM, Stephen Gallagher wrote:
> On 10/26/2010 06:08 AM, Jakub Hrozek wrote:
>> On 10/25/2010 07:02 PM, Stephen Gallagher wrote:
>>> On 10/25/2010 12:36 PM, Jakub Hrozek wrote:
>>>> On 10/25/2010 04:12 PM, Stephen Gallagher wrote:
>>>>> On 10/25/2010 09:44 AM, Jakub Hrozek wrote:
>>>>>> As discovered by QA, we were not consistent across architectures with
>>>>>> our handling of UID numbers. This patch converts to strtouint32(), so we
>>>>>> use the fixed-width uint32_t everywhere.
>
>>>>>> Attached are patches for both master and 1.2, where the patch also fixes
>>>>>> one additional place which was still using strtol().
>
>
>>>>> Nack:
>>>>> find_uid.c:(.text+0x9ef): undefined reference to `strtouint32'
>
>>>>> (Looks like find_uid-tests isn't linking against strtonum.o)
>
>
>
>>>> Thanks, new patches attached. Also fix two issues in strtonum tests.
>
>
>>> Nack. The changes you made to the strtonum tests are just wrong. You
>>> aren't using "actual" anywhere, and for the "expected" values, you're
>>> not printing the correct strerror()
>
>
>> Right, this patch hopefully makes strtonum tests work better, not just
>> by accident.
>
>
>
> Ack to both versions.
>
Pushed to master, sssd-1-2 and sssd-1-4 as appropriate.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkzGw+sACgkQeiVVYja6o6MxAgCbBi8+e67eUsUTXIFTZyzLR9aw
5WAAn13CsONFQSM5LEo0rNOYM44BA8p6
=1tmN
-----END PGP SIGNATURE-----
More information about the sssd-devel
mailing list