[SSSD] [PATCHES] Netgroups for proxy provider

Stephen Gallagher sgallagh at redhat.com
Fri Oct 22 14:43:11 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/22/2010 08:41 AM, Sumit Bose wrote:
> On Fri, Oct 22, 2010 at 08:10:10AM -0400, Stephen Gallagher wrote:
> On 10/20/2010 05:34 AM, Sumit Bose wrote:
>>>> Hi,
>>>>
>>>> there two patches add netgroups support for the proxy provider as
>>>> requested in ticket #630.
>>>>
> 
> Nack.
> 
> If ctx->ops.getnetgrent_r() returns an error in get_netgroup(), you're
> leaking memory.
> 
>> fixed
> 
> 
> Typo in make_netgroup_attr(): "netgrentoupt"
> 
>> fixed
> 
> 
> Otherwise, it looks good.
> 
>> Thanks for the review, new version attached.

Ack to both.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzBov8ACgkQeiVVYja6o6O5IgCeMvJdL/D66V/3tuRwYsocUiWf
e2cAoJaNYH/wumLLBIBblKHYl/dJ4let
=/E/H
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list