[SSSD] [PATCH] Use unsigned long for conversion to id_t

Stephen Gallagher sgallagh at redhat.com
Mon Oct 18 15:40:02 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2010 10:25 AM, Jakub Hrozek wrote:
> We used strtol() on a number of places to convert into uid_t or gid_t
> from a string representation such as LDAP attribute, but on some
> platforms, unsigned long might be necessary to store big id_t values.
> 
> This patch converts to using strtoul() instead.
> 
> Fixes: #650


Nack. Throws a new warning:

cc1: warnings being treated as errors
../src/util/find_uid.c: In function ‘get_uid_from_pid’:
../src/util/find_uid.c:146: error: comparison of unsigned expression < 0
is always false


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAky8alIACgkQeiVVYja6o6NApwCgkYW0AWxwLkXJw57mcm59PhT8
2rIAn3Nmv64ZceJlJuLfTsPYtU3A59Rf
=UNS9
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list