[SSSD] [PATCHES] Initgroups support for RFC2307bis nested groups (master)

Stephen Gallagher sgallagh at redhat.com
Mon Oct 18 12:07:23 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2010 07:15 AM, Jakub Hrozek wrote:
> On 10/18/2010 03:04 AM, Stephen Gallagher wrote:
>> Patch 0001: Modify sysdb_[add|remove]_group_member to accept users and
>> groups
> 
>> Previously, it assumed that all members were users. This changes
>> the interface so that either a user or a group can be specified.
> 
>> Also, it eliminates the need for a memory context to be passed,
>> since the internal memory should be self-contained.
> 
> 
> 
> Ack
> 
>> Patch 0002: Add proper nested initgroup support for RFC2307bis servers
> 
> 
>> Both of these patches are forward-ported from SSSD 1.2.4 (adjusting for
>> sysdb changes).
> 
> 
> Two minor issues - in rfc2307bis_nested_groups_step(), the second
> sysdb_attrs_get_string() for SYSDB_NAME is not needed.
> 

Thanks, that was a cut-and-paste where I forgot the "cut" step :)

> In rfc2307bis_nested_groups_process(), there should be a return
> following the tevent_req_error() after calling
> rfc2307bis_nested_groups_step(). The same code is also in
> rfc2307bis_nested_groups_done().
> 
> Otherwise looks OK.
> 

You are correct about rfc2307bis_nested_groups_done(). However, there's
no issue in rfc2307bis_nested_groups_step(). For economy of space, I
just included a single return statement outside the if/else blocks.

New patch attached.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAky8OHsACgkQeiVVYja6o6OECACdGEceacBsCzuRMFQb0v3lAy0X
sPQAn1NxPOc1BrGAGs6eMQZ5qu0Dr5k2
=7ZLX
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Modify-sysdb_-add-remove-_group_member-to-accept-use.patch
Type: text/x-patch
Size: 11645 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101018/b1bc3af4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-proper-nested-initgroup-support-for-RFC2307bis-s.patch
Type: text/x-patch
Size: 25270 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101018/b1bc3af4/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Modify-sysdb_-add-remove-_group_member-to-accept-use.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101018/b1bc3af4/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-proper-nested-initgroup-support-for-RFC2307bis-s.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101018/b1bc3af4/attachment-0001.sig>


More information about the sssd-devel mailing list