[SSSD] [PATCHES] Initgroups support for RFC2307bis nested groups (sssd-1-2)

Stephen Gallagher sgallagh at redhat.com
Fri Oct 8 20:14:31 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/08/2010 02:57 PM, Stephen Gallagher wrote:
> On 10/08/2010 10:37 AM, Stephen Gallagher wrote:
>> On 10/08/2010 07:54 AM, Stephen Gallagher wrote:
>>> On 10/08/2010 06:25 AM, Sumit Bose wrote:
>>>>> the tmp_ctx in rfc2307bis_nested_groups_incomplete_groups_save() needs
>>>>> to be initialised to NULL.
> 
>>> Good catch. Fixed.
> 
> 
> 
>> I discovered a bug in the original patch 0003. I was asking the sysdb
>> for the list of memberOf entries for the user so I could compare it with
>> the list I was getting from LDAP.
> 
>> However, the sysdb lists nested parents in memberOf, not just direct
>> parents, so I was getting errors trying to delete the user as a member
>> from the toplevel parent groups.
> 
>> The new version of patch 0003 now does a search through the groups for
>> groups with member=user_dn. This returns the correct list of direct
>> parents only.
> 
>> Patches 0001 and 0002 are unchanged from the previous submission,
>> they're just included to make it easier to keep track.
> 
> 
> 
> I found a bug where I wasn't checking if the reply from a sysdb lookup
> was ENOENT (which is valid) and was returning it as an error.
> 
> New patches attached.
> 


Jakub discovered a bug with deep nesting. I only fixed the direct
membership lookup for users, but not for other groups.

This version of the patch combines this into a common routine so that
both users and groups check for direct parentage in the sysdb.



- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyve6YACgkQeiVVYja6o6MnKACgjzOFz8TRgPTUumUrMcj/oU2j
fPEAnAsOKJKDydJuBG1YC2XTLOYWuSJt
=wL4f
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-user-argument-of-sysdb_update_members_send-a-co.patch
Type: text/x-patch
Size: 1944 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101008/38872dfe/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Modify-sysdb_add_group_member_send-to-accept-users-a.patch
Type: text/x-patch
Size: 13129 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101008/38872dfe/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-proper-nested-initgroup-support-for-RFC2307bis-s.patch
Type: text/x-patch
Size: 35339 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101008/38872dfe/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-user-argument-of-sysdb_update_members_send-a-co.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101008/38872dfe/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Modify-sysdb_add_group_member_send-to-accept-users-a.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101008/38872dfe/attachment-0001.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-proper-nested-initgroup-support-for-RFC2307bis-s.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101008/38872dfe/attachment-0002.sig>


More information about the sssd-devel mailing list