[SSSD] [PATCHES] Handle nested groups in RFC2307bis (sssd-1-2)

Jakub Hrozek jhrozek at redhat.com
Fri Oct 8 15:12:32 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/08/2010 02:32 PM, Stephen Gallagher wrote:
> On 10/08/2010 08:09 AM, Jakub Hrozek wrote:
>> On 10/08/2010 01:13 PM, Stephen Gallagher wrote:
>>> On 10/08/2010 05:25 AM, Jakub Hrozek wrote:
>>>> On 10/07/2010 03:18 PM, Stephen Gallagher wrote:
>>>>> Whoops, I guess I missed a few spots. I meant to remove references to
>>>>> that option, because we're not using it for now.
> 
>>>> Update patch attached. I hope you don't mind me touching your patches
>>>> but I did the fix change anyway in-tree, so why not submit it :-)
> 
> 
>>> Sure, I'll merge this into my patch this morning, along with the memory
>>> hierarchy fix. Sorry I didn't get to it last night.
> 
> 
>> I also think there needs to be some kind of guard in
>> sdap_nested_groups_done when there are no users as we unconditionally
>> alloc the "users" array but its contents are NULL..or maybe a better fix
>> would be to make sdap_save_users_send just mark the request done if
>> count==0.
> 
>> 	Jakub
> 
> Patch 0001: Revised patch that Jakub sent out.
> Patch 0002 (New): Make sdap_save_users_send handle zero users gracefully
> 
> If we send a zero num_users value, we should just immediately
> return success, rather than starting a useless transaction
> 
> Patch 0003: Cleaned up the memory hierarchy in sdap_get_groups_process()
> and fixed up sdap_nested_done() so that if count is zero, we won't
> attempt to allocate a size-zero array.
> 
> 

I don't have any more comments and my testing went alright. So ack from
me, although I'm not sure if someone else is reviewing the patch, too?
I think Sumit was looking at them.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyvNOAACgkQHsardTLnvCUC7QCdFV1I/nrS4g+hEI3Wx+X6WKDD
GrUAoNeFbzlGwEw5Cw5LxOr0qM9uDMzZ
=i0ue
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list