[SSSD] [PATCH] Return all user members for RFC2307 groups (sssd-1.2)

Stephen Gallagher sgallagh at redhat.com
Fri Oct 8 14:57:03 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/08/2010 05:09 AM, Jakub Hrozek wrote:
>>>> [PATCH 1/3] sysdb interface for adding expired user entries
>>>> These are added instead of looking up the members.

Ack.

>>>> [PATCH 2/3] Shortcut for save_group() to accept sysdb DNs as member
>>>> attributes

Nack. I would rather we use an enum here instead of adding extra
booleans to the interface. Otherwise it's fine. (I would have made the
same comment to Ralf had I been the one to review this code)

>>>> [PATCH 3/3] Add fake users during saving of RFC2307 group
>>>> Instead of looking up the user entries, we just add dummy expired
>>>> users that are refreshed when they are requested with
>>>> getpwnam/getpwuid

Nack.

sdap_process_group_send(): Please allocate attrs, filter and
grp_state->sysdb_dns atop grp_state and grp_state->sysdb_dns->values
atop grp_state->sysdb_dns. Allocating them on memctx means that they
will not go away until the parent memory context does. These values are
only needed for the lifetime of this request. If the parent memory
context lives a long time, this is basically a memory leak.

Otherwise, I'm fine with this patch.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyvMT8ACgkQeiVVYja6o6NHcwCgkCDCyIZhECQ/P4tqmQfmRmog
Cw8An1nn/mJCWRBgB4Yi8Yh2cOQvP3b0
=cjMm
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list