[SSSD] [PATCH] Save dummy groups to cache during initgroups (sssd-1.2)

Jakub Hrozek jhrozek at redhat.com
Wed Oct 6 09:24:50 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/05/2010 10:55 PM, Simo Sorce wrote:
> Sorry, retiring my ack for a minor issue.
> 
> If these are fake groups it makes no sense to be able to pass in the
> group GID. We should have in the header a FAKE_GID_NUMBER definition
> and just hardcode that we assign that macro to the gidnumber.
> 
> So can you please change the sysdb_add_fake_group_send() interface to
> *not* have an argument for the gid ?
> 
> Simo.
> 

I think this comment makes a lot of sense for saving expired users and I
will change my other patches accordingly.

But for saving expired groups, I wanted to also save the GID explicitly
- - the main rationale being getgrouplist(3) working correctly. I think
there's no penalty since for RFC2307 we have to lookup the groups anyway
so we have the GID ready.

	Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkysQGIACgkQHsardTLnvCWk3QCfZsFMTLXuk9AT3HZCmodFVMOv
1/oAnicx8qjW3hS7sWmhC9gd+/HTt/oC
=lmRG
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list