[SSSD] [PATCH] Print correct error messages for dp_err_to_string()

Stephen Gallagher sgallagh at redhat.com
Fri Nov 19 19:23:21 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

All errnum values passed into this function throughout the code
are PAM error codes, but we were passing them through strerror()
to print them, which is only meaningful for ERRNO error codes.

This patch changes dp_err_to_string() to use pam_strerror().

Fixes https://fedorahosted.org/sssd/ticket/636

Note: the first argument to pam_strerror() requiring a PAM handle is
historical and not necessary. I tested that passing it NULL results in
no unexpected behavior.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzmzqkACgkQeiVVYja6o6PIXwCgqWXP1Sm1ym1PaDcWeBjgxB+K
FcQAn3o5A0KmgT/Z0X0itrTmqiO3sGQl
=1LHe
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Print-correct-error-messages-for-dp_err_to_string.patch
Type: text/x-patch
Size: 2288 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101119/684108bf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Print-correct-error-messages-for-dp_err_to_string.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101119/684108bf/attachment.sig>


More information about the sssd-devel mailing list