[SSSD] [PATCH] Fix authentication queue code for proxy auth

Sumit Bose sbose at redhat.com
Wed Nov 17 19:38:47 UTC 2010


On Wed, Nov 17, 2010 at 02:32:39PM -0500, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 11/17/2010 04:22 AM, Sumit Bose wrote:
> >> Can you call 'client_ctx->auth_ctx->running--;' directly after
> >> 'proxy_child_recv()' ?
> > 
> 
> Sure, I just moved the decrement and the creation of the immediate event
> to before the return value check, so now it will happen regardless of
> the result code. This also eliminates the code duplication in my
> previous patch for creating the immediate event.

if the proxy_child fails and tevent_create_immediate(), too,
proxy_reply() is not called.

bye,
Sumit

> 
> - -- 
> Stephen Gallagher
> RHCE 804006346421761
> 
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAkzkLdMACgkQeiVVYja6o6PpFwCfRfMM3Pv5jKoIv0xXGkFtn3lI
> ydEAniJHN2NIQVCH9vvPzezfbThmLKDG
> =X89X
> -----END PGP SIGNATURE-----



More information about the sssd-devel mailing list