[SSSD] [PATCH] Sanitize ldap attributes in the config file

Sumit Bose sbose at redhat.com
Mon Nov 15 14:03:33 UTC 2010


On Mon, Nov 15, 2010 at 08:51:21AM -0500, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 11/15/2010 07:34 AM, Sumit Bose wrote:
> >> ah, sorry, I should have read the context. But after reading it I still
> >> have comments:
> 
> >> this 'if'  is redundant
> 
> >> If I remember correctly there is no debugging output in
> >> sss_filter_sanitize(), so I think it would be helpful to have a more
> >> specific message if either the retrieval or the sanitation failed.
> 
> Thanks for the review. New patch attached.

ACK

bye,
Sumit

> 
> - -- 
> Stephen Gallagher
> RHCE 804006346421761
> 
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAkzhOtkACgkQeiVVYja6o6O0fACdGPQxNJL1Nl+he1SDXF63Q8DQ
> MHAAn2FERem5uran44MyzGWdHIPISNop
> =KjcN
> -----END PGP SIGNATURE-----



More information about the sssd-devel mailing list