[SSSD] [PATCHES] Sanitize search filters in the sysdb

Stephen Gallagher sgallagh at redhat.com
Thu Nov 11 17:04:23 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/10/2010 10:07 AM, Sumit Bose wrote:

>> I have only minor comment, please find them below ...

> Why do you create a tmp_ctx on the two cases above and just use NULL in
> the following three cases? I think using NULL is sufficient in all
> cases.


I've changed sysdb_custom_subtree_dn() to use NULL, but I left
sysdb_custom_dn() alone with using tmp_ctx. This is mostly just because
it reads cleaner, since there are two sanitized values in this function.

All other recommended changes are made. Thank you for the review. New
patches attached.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzcIhYACgkQeiVVYja6o6PUKgCfcyU3P3ZDt0lt2bkCLig2LfRr
j3IAoIMpKp6vTXVrHsyQ/SUuIK2T+mTU
=53CM
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-utility-function-to-sanitize-LDAP-LDB-filters.patch
Type: text/x-patch
Size: 6223 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-sysdb-utility-function-for-sanitizing-DN.patch
Type: text/x-patch
Size: 1865 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Sanitize-search-filters-for-the-sysdb.patch
Type: text/x-patch
Size: 4727 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Sanitize-sysdb-search-filters-in-the-IPA-provider.patch
Type: text/x-patch
Size: 3112 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Sanitize-sysdb-filters-in-the-LDAP-provider.patch
Type: text/x-patch
Size: 2431 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Sanitize-sysdb-DN-helpers.patch
Type: text/x-patch
Size: 3959 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Sanitize-search-filters-in-memberOf-plugin.patch
Type: text/x-patch
Size: 3330 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Sanitize-sysdb-dn-for-memberof-lookup.patch
Type: text/x-patch
Size: 1866 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Add-unit-tests-for-users-and-groups-with-odd-charact.patch
Type: text/x-patch
Size: 6864 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-utility-function-to-sanitize-LDAP-LDB-filters.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-sysdb-utility-function-for-sanitizing-DN.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0001.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Sanitize-search-filters-for-the-sysdb.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0002.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Sanitize-sysdb-search-filters-in-the-IPA-provider.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0003.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Sanitize-sysdb-filters-in-the-LDAP-provider.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0004.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Sanitize-sysdb-DN-helpers.patch.sig
Type: application/pgp-signature
Size: 71 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0005.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Sanitize-search-filters-in-memberOf-plugin.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0006.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Sanitize-sysdb-dn-for-memberof-lookup.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0007.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Add-unit-tests-for-users-and-groups-with-odd-charact.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101111/c53f79d3/attachment-0008.sig>


More information about the sssd-devel mailing list