[SSSD] [PATCHES] Use namingContext to set empty search bases

Stephen Gallagher sgallagh at redhat.com
Thu Nov 4 17:42:31 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/03/2010 09:19 AM, Sumit Bose wrote:
> On Wed, Nov 03, 2010 at 08:48:21AM -0400, Simo Sorce wrote:
>> On Tue, 2 Nov 2010 22:39:45 +0100
>> Sumit Bose <sbose at redhat.com> wrote:
>>
> ....
>>> memberOf=cn=allowedusers,ou=Groups,dc=example,dc=com </para>
>>>                          <para>
>>>                              Default: the value of
>>> -                            <emphasis>ldap_search_base</emphasis>
>>> +                            <emphasis>ldap_search_base</emphasis> or
>>> the value
>>> +                            of the namingContexts attribute of the
>>> RootDSE of the
>>> +                            LDAP server.
>>>                          </para>
>>>                      </listitem>
>>>                  </varlistentry>
>>
>> NACK, with the change to support defaultNamingContext, these
>> explanations are not correct anymore.
> 
> Thanks for catching this. New versions attached.
> 


Nack. Please clean up the tabs in sdap_get_rootdse_send() for the
attrs[] list.

Please use a different loop-control variable than "o" in
sdap_set_config_options_with_rootdse(). It's difficult to differentiate
at a glance between search_base_options[o] and search_base_options[0].

It's probably less confusing to leave the ldap_*_search_base manpage
entries saying that they default to the value of ldap_search_base.
Reading the manpage entry for that option will provide all of the
necessary information.

Right now, the way these specific options read is ambiguous (does it use
ldap_search_base, namingContexts or defaultNamingContexts?).



- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzS8IcACgkQeiVVYja6o6PkZQCgqtUzQyYXEqSdtl7gbl8V1AZq
T6sAoJGa80W5gnKrtbuwNmR6Yxtv99nh
=fjKc
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list