[SSSD] [PATCH] Handle errors during log reopening better

Stephen Gallagher sgallagh at redhat.com
Thu Nov 4 15:00:53 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/04/2010 10:36 AM, Stephen Gallagher wrote:
> On 11/04/2010 10:10 AM, Stephen Gallagher wrote:
>> On 11/04/2010 10:06 AM, Simo Sorce wrote:
>>> On Thu, 04 Nov 2010 09:04:37 -0400
>>> Stephen Gallagher <sgallagh at redhat.com> wrote:
> 
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA1
>>>>
>>>> This patch makes two changes:
>>>>
>>>> 1) If we receive an error from rotating the logs, add it to the syslog
>>>> message
>>>> 2) Check for EINTR when closing the debug file and retry.
>>>>
>>>> This will either resolve https://fedorahosted.org/sssd/ticket/668 or
>>>> at minimum help identify it.
> 
>>> This patch still doesn't reopen logs if fclose() fails for other
>>> reasons than EINTR, is that what you meant ?
> 
>> Yeah, I sent this before we discussed that. This patch was mainly for
>> diagnostic purposes.
> 
>> Self-nack. I'll revise the patch to do the reopening.
> 
> 
> 
> This should be more like it.
> 

Simo noted offline that some of the checks were redundant. I've
streamlined the patch somewhat now.


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzSyqUACgkQeiVVYja6o6N5YgCdEy6zBJi6GlUZtjxFIl9gneen
lwUAnRngP4P5xTRDCUmkswQmpHMxF2zq
=2DF+
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Handle-errors-during-log-reopening-better.patch
Type: text/x-patch
Size: 2450 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101104/27630bdc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Handle-errors-during-log-reopening-better.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101104/27630bdc/attachment.sig>


More information about the sssd-devel mailing list