[SSSD] [PATCHES] Assorted patches related to the proxy PAM provider (master)

Stephen Gallagher sgallagh at redhat.com
Thu May 27 18:50:30 UTC 2010


On 05/27/2010 11:52 AM, Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/27/2010 05:29 PM, Stephen Gallagher wrote:
>> I'd prefer not to include that in this patch. As best I can tell, it's
>> only an issue in the NSS proxy routines, not PAM.
>>
>
> OK, agreed.
>
>> We should not be initializing ret, we should be guaranteeing that it is
>> always returned with an appropriate value.
>> If we initialize it, we're
>> potentially hiding an error.
>
> Just to clarify why I was suggesting initializing..the call that is
> supposed to fill *ret is ctx->ops.initgroups_dyn which points to
> to nss-ldap's _nss_ldap_initgroups_dyn(). Since it's already external
> call, initializing the ret variable seemed OK to me.
>
>> That's a much bigger task and deserves its
>> own ticket (please open one) and patch.
>>
>
> Done:
> https://fedorahosted.org/sssd/ticket/498
>
>> If you have no other issues with this patch, I will push it as-is.
>
> ACK, go ahead


Pushed all to master.

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



More information about the sssd-devel mailing list