[SSSD] [PATCHES] Fix LDAP timeout values

Stephen Gallagher sgallagh at redhat.com
Tue May 18 15:03:00 UTC 2010


On 05/18/2010 10:49 AM, Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/18/2010 04:29 PM, Stephen Gallagher wrote:
>> On 05/18/2010 10:20 AM, Stephen Gallagher wrote:
>>> Patch 0001: The option ldap_offline_timeout is not used anywhere in the
>>> source. This patch removes references to it.
>>>
>
> Can we also remove the option from SSSDConfig.py?
>

Whoops, forgot that. Fixed.

> If needed, I could also amend the upgrade-config.py to remove the option
> from the config file, although it does not hurt in any way to keep it.

Actually, it does hurt to keep it. Because if it exists, then the config 
API will throw a parse error if e.g. authconfig tries to edit the config 
file.

So we probably should add that to the upgrade-config.py. Added that to 
the new patch.

>
>>> Patch 0002: The manpage lists five seconds as the default for ldap
>>> searches, but the source was setting the default to 60s. This was
>>> causing long timeouts waiting to go offline.
>>>
>
> Ack
>
>>
>> As Jakub noted off-list, these patches only apply cleanly atop Sumit's
>> "Add offline callback and fix info file handling" patches.
>>

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-unused-ldap_offline_timeout-option.patch
Type: text/x-patch
Size: 6609 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100518/282c4b4a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Set-ldap_search_timeout-default-to-5-seconds.patch
Type: text/x-patch
Size: 2382 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100518/282c4b4a/attachment-0001.bin>


More information about the sssd-devel mailing list