[SSSD] [PATCH] Add ldap_access_filter option

Stephen Gallagher sgallagh at redhat.com
Thu May 13 18:02:57 UTC 2010


On 05/13/2010 12:07 PM, Simo Sorce wrote:
> On Thu, 13 May 2010 10:56:35 -0400
> Stephen Gallagher<sgallagh at redhat.com>  wrote:
>
>> +    ret = sysdb_attrs_add_uint32(attrs, SYSDB_LDAP_ACCESS,
>> +                                 state->pam_status == PAM_SUCCESS ?
>> +                                                      true :
>> +                                                      false);
>
> Just a nitpick, but normally in LDAP true false values are stored as
> the strings "TRUE" or "FALSE" (upper case). It makes it clearer this is
> a boolean attribute than storing 0 vs a random value (usually 1).
>
> Simo.
>

New patch attached. I added a new sysdb function: sysdb_attrs_add_bool() 
that will handle this in an ldb-compatible way.

I also corrected your other comment about passing an explicit event context.

Finally, this patch adds the new option to the SSSDConfig API and 
manpages (which I forgot to do originally).

Please re-review.

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-ldap_access_filter-option.patch
Type: text/x-patch
Size: 33408 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100513/1af7830c/attachment.bin>


More information about the sssd-devel mailing list