[SSSD] [PATCH] Add dynamic DNS updates to FreeIPA

Jakub Hrozek jhrozek at redhat.com
Fri May 7 19:44:41 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/06/2010 07:54 PM, Stephen Gallagher wrote:
> On 05/05/2010 04:37 AM, Sumit Bose wrote:
>> On Tue, May 04, 2010 at 11:11:51PM +0200, Jakub Hrozek wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> On 05/04/2010 08:54 PM, Stephen Gallagher wrote:
>>>> New patch attached.
>>>
>>> fwiw, I don't have any more concerns, ack from me. Let's see if Sumit
>>> has any more comments :)
>>
>> The patch looks fine, but currently I'm not able to really test it. So
>> it is also an ACK from me, but if you want me to do more testing you
>> have to wait until tomorrow.
>>
>> bye,
>> Sumit
> 
> I found a double-free error in the patch, and in doing so ended up
> updating the SIGCHLD patch to address it. The attached patch is rebased
> atop those changes.
> 
> 

I don't have any more comments to the code and also my testing shows
that this feature works correctly - ACK.

Great work!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkvkbakACgkQHsardTLnvCXsDQCfZokstM/aXl8YyarOBBczth5l
duoAoJFV+ZuTEBhSnglrQEwHPUdK5kfn
=uKPZ
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list