[SSSD] [PATCH 6/6] Fix segfault in GSSAPI reconnect code

Stephen Gallagher sgallagh at redhat.com
Fri May 7 14:53:37 UTC 2010


On 05/07/2010 10:51 AM, Eugene Indenbom wrote:
> On 05/07/2010 06:43 PM, Dmitri Pal wrote:
>> Eugene Indenbom wrote:
>>
>>> One correction (not really important): an error in
>>> sdap_account_info_restart(breq) should not put backend to offline:
>>>
>>>
>> If you do this way shouldn't you set the errstr too?
>>
>>
>>
> Sure, just could not think out a good text right away.
> But the main point is that sdap_mark_offline is in else branch.

Could you explain why you think that this shouldn't be marked offline 
here? An error from sdap_account_info_restart(breq) only occurs if we 
cannot restart the connection. (It only fails on too many retries or out 
of memory). In either case, we really should be offline.

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



More information about the sssd-devel mailing list