[SSSD] [PATCH] Make ldap simple bind asynchronous

Martin Nagy mnagy at redhat.com
Mon May 3 16:29:02 UTC 2010


On Fri, 2010-04-23 at 14:49 +0200, Martin Nagy wrote:
> Hi,
> here it is. I included some description in the commit log, it is
> necessary to read it in order to understand why I did some things this
> way. Any suggestions to make the patch better are most welcome.
> 
> Martin

New patches after some comments from Simo on IRC. The comments were:

Allocate fd_event_item on cb_data and simply use destructor
appended to a memory context that depends on the request to
remove it.

Remove simple_bind_wakeup_op_add() and instead use a boolean
in state that simple_bind_wakeup_bind() checks first to see
what operation to do.

The tevent_req_post() in simple_bind_wakeup_op_add() shouldn't
be there.

My own: Add forgotten timeout.

Move ldap_finish_bind to sdap_async.c.

These were all fixed.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-ldap-simple-bind-asynchronous.patch
Type: text/x-patch
Size: 16879 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100503/1663e82a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-a-test-for-LDAP-bind.patch
Type: text/x-patch
Size: 11029 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100503/1663e82a/attachment-0001.bin>


More information about the sssd-devel mailing list