[SSSD] [PATCH] Properly set up SIGCHLD handlers

Stephen Gallagher sgallagh at redhat.com
Mon May 3 13:39:44 UTC 2010


On 05/03/2010 07:36 AM, Stephen Gallagher wrote:
> On 05/02/2010 05:19 PM, Stephen Gallagher wrote:
>> On 05/02/2010 03:37 PM, Stephen Gallagher wrote:
>>> On 05/02/2010 08:10 AM, Stephen Gallagher wrote:
>>>> Previously, we could set up more than one handler for the same
>>>> backend, because the LDAP and Kerberos providers each set one up.
>>>>
>>>> See https://fedorahosted.org/sssd/ticket/460 for more detail on the
>>>> issue this patch addresses.
>>>>
>>>> Please review this patch promptly, as it is a dependency for my dyndns
>>>> patch that I am working on.
>>>
>>> Withdrawing this patch. I have a better way (patch coming later today).
>>>
>>
>> Ok, new version of this patch (much more involved).
>>
>> Now, instead of setting up a global handler for all children, we will
>> set up individual handlers for the PIDs we care about.
>>
>> This patch also adds functionality to allow setting a callback on the
>> signal handler, to get the results back.
>>
>
> Sumit spotted a mistake in the patch during review. There were too many
> arguments being passed to sdap_fork_child().
>
> New patch attached.
>

I found a logic bug. It was only calling the callback when the child 
succeeded. It will now return the errors as well.

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Properly-set-up-SIGCHLD-handlers.patch
Type: text/x-patch
Size: 11964 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100503/181418dd/attachment.bin>


More information about the sssd-devel mailing list