[SSSD] [PATCH] Improvements for LDAP Password Policy support

Simo Sorce ssorce at redhat.com
Thu Mar 18 11:42:23 UTC 2010


On Wed, 17 Mar 2010 15:33:38 +0100
Ralf Haferkamp <rhafer at suse.de> wrote:

> Hi,
> 
> here's another set of enhancements to the LDAP Password Policy
> support in the PAM module and the LDAP backend. The PAM module now
> issues warning when either the grace counter or the expire counter of
> the LDAP Ppolicy Control in > 0. 
> 
> Addtionally I changed the detection for Ppolicy support of the LDAP 
> Server a bit. If the Server returned the Ppolicy Control in the Bind 
> Response  ppolicy support is assumed.
> 
> I left the original check for "pwdAttribute" intact, though I think
> it doesn't make a lot of sense. The "pwdAttribute" LDAP Attribute is
> usually not part of the user's entry, it's part of the Entry that
> contains the Policy. Addtionally it might be protected by ACLs and
> not be returned for anonymous (without losing any functionality).
> 

Ralf,
patch looks mostly good, but there are some heavy coding style
violations.

if ( condition ){ is not good, it should be: is (condition) {

same for some functions foo( ccc ); is not good, use foo(ccc);

Ie, no space in parenthesis, a space only after keywords, and
always before the opening {

Don't use ++x, but x++ if possible.

Also there is at least one place where the return of talloc is not
checked.

Finally please try to keep the 80 columns limit where possible.


Simo.

-- 
Simo Sorce * Red Hat, Inc * New York



More information about the sssd-devel mailing list