[SSSD] [PATCH] Doxygen docs for INI

Dmitri Pal dpal at redhat.com
Mon Mar 15 18:31:38 UTC 2010


Stephen Gallagher wrote:
> On 03/15/2010 02:15 PM, Dmitri Pal wrote:
> > Stephen Gallagher wrote:
> >> On 03/15/2010 01:11 PM, Dmitri Pal wrote:
> >>> Hi,
> >>> Please find attached a patch that updates the ini_config.h to generate
> >>> doxygen docs.
> >>> I realized that it would be easier to push this out of the way and
> then
> >>> rework the other patch that I need to rework.
> >>> It would be simpler to rework it on top of this one then vice versa.
> >>> Thus sending this one.
> >>
> >> Ack to this patch. Please review my attached patch to include these
> docs
> >> in the RPM package.
> >>
> > I am not at all a spec expert but would the change:
> > -pushd common/collection
> > +pushd common
>
> > have some impact on the other directories under common that are not
> > documented yet or we have all the directories documented now?
>
> > I would have expected:
> > pushd common/collection
> > +pushd common/ini
>
> > rather then the one you have, but may be you are right...
>
>
> I actually did it wrong in the first place. In the Makefile.am for the
> common directory, we have the DOCDIRS variable which specifies which
> subdirectories to generate docs for. I updated that variable to include
> ini, and I changed the pushd in the spec file to run it from the common
> directory, instead of running it explicitly for both collection and ini.
>
Ok I do not have any other comments but I can't be counted as authority.


_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list