[SSSD] [PATCHES] Different patches for COLLECTION and INI

Stephen Gallagher sgallagh at redhat.com
Fri Mar 12 14:13:51 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/12/2010 07:52 AM, Stephen Gallagher wrote:
> On 03/11/2010 12:38 PM, Dmitri Pal wrote:
>> Hi,
> 
>> Patch 1 - one-liner, turn off man page generation
> Ack.
> 
>> Patch 2 - cleaning INI unit test to comply with formatting guidelines
>> and to turn off endless output in case of "make check".
> Ack.
> 
>> Patch 3 - addressing ticket #170
> Nack. Please update the function names to reflect that the argument they
> take is uint32_t, etc
> e.g. col_add_int_property() -> col_add_int32_property()
> 
> I am aware that you will need to update any places in the collection and
> INI where these functions are called.
> 
>> Patch 4 - continuation of the work related on patch 3 regarding INI
>> interface that uses collection interface internally.
> Nack. (Nitpick)
> In the get_*_config_value() functions, if the return value of
> get_long_config_value() is outside the expected range, the correct error
> code to return should be ERANGE, not EIO.

Patches 1 and 2 pushed to master and 1-1-0

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkuaTB8ACgkQeiVVYja6o6PdzACgmTEnnETKAd7CI7TuSnqKTTGb
MfUAn1z2mgznEf5FK4r0BuuLY5DNNvhC
=knaC
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list