[SSSD] [PATCHES] Different patches for COLLECTION and INI

Jakub Hrozek jhrozek at redhat.com
Fri Mar 12 13:00:34 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/12/2010 01:52 PM, Stephen Gallagher wrote:
>> Patch 3 - addressing ticket #170
> Nack. Please update the function names to reflect that the argument they
> take is uint32_t, etc
> e.g. col_add_int_property() -> col_add_int32_property()
> 
> I am aware that you will need to update any places in the collection and
> INI where these functions are called.
> 

I also think that the get_ulong_config_value() function is not OK as
under the hood (in get_long_config_value()) it uses strtol(), which
would error out if the value being converted was bigger than LONG_MAX.

Agreed with the other points :-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkuaOvIACgkQHsardTLnvCWfNwCgnRv0A7TVTltiMlB/lYW64JGk
2K4AoNFWdMmQ7LN2D6lxYglW6lql49eS
=/xiY
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list