[SSSD] [PATCH] Unbreak the build when check-devel is not installed or of sufficient version

Stephen Gallagher sgallagh at redhat.com
Thu Mar 11 14:59:36 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/11/2010 07:17 AM, Stephen Gallagher wrote:
> On 03/10/2010 05:26 PM, George McCollister wrote:
>> Stephen,
> 
>> It turns out I do have check for my target. To get things working I had
>> to add $(CHECK_LIBS) to stress_tests_LDADD. Applying this patch caused
>> even more problems because HAVE_CHECK is not defined in config.h even
>> when configure finds check. I should be on IRC tomorrow if you want to
>> talk about it.
> 
>> George
> 
>> On 03/10/2010 09:53 AM, Stephen Gallagher wrote:
>> I discovered when trying to build RPMs on EPEL5 (which does not have a
>> compatible version of check) that the build failed trying to link the
>> common.c test utilities.
> 
> 
> Thanks for your testing, George. Turns out I wasn't doing the check
> correctly. New patch attached, which will hopefully fix things for you.
> 


Another version of the patch. This time I'm just splitting out the
check-specific common code into its own .c file, which will be
conditionally-compiled. Hopefully this will fix it for good.


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkuZBVgACgkQeiVVYja6o6OTrACfQAAbXjMRoveLV0cplVtkMFhQ
9G0AnA11ek2/ToidpnWp0LhJSrKtYnCD
=aexa
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-build-when-check-devel-is-not-installed.patch
Type: text/x-patch
Size: 5178 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100311/04196fbc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-build-when-check-devel-is-not-installed.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100311/04196fbc/attachment.sig>


More information about the sssd-devel mailing list