[SSSD] [PATCH] Make filter_users and filter_groups also per-domain

Stephen Gallagher sgallagh at redhat.com
Mon Mar 8 18:46:58 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/08/2010 01:35 PM, Stephen Gallagher wrote:
> On 03/08/2010 01:26 PM, Jakub Hrozek wrote:
>> On 03/08/2010 05:34 PM, Stephen Gallagher wrote:
>>> On 03/04/2010 11:02 AM, Jakub Hrozek wrote:
>>>> On 03/03/2010 08:44 PM, Jakub Hrozek wrote:
>>>>> Fixes: 290
> 
>>>> Self-nack, the attached patch fixes a bug related to error handling in
>>>> the patch.
> 
>>> Nack.
> 
>>> If you set filter_users or filter_groups in a domain, but do not also
>>> have it set in [NSS], the configuration fails with ENOENT, because
>>> if (ret == ENOENT && !filter_set) is false.
> 
>>> Also, while you're in there, could you fix the impending segfault after
>>> filter_list = talloc_array(tmpctx, char *, 2);
> 
>>> Instead of checking for NULL here, it's not tested until after
>>> attempting to assign to filter_list[0].
> 
> 
>> Thank you for the review, a new patch is attached.
> 
> Ack.
> 

Pushed to master and 1-1-0.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkuVRiIACgkQeiVVYja6o6NXewCgpZWPnCDvPtGkpTdbYRKePE7O
iN0AoIyHHYX0/hl5FF0dhlJeHUBFe5HN
=uPOT
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list