[SSSD] [Patch] Improvements for the Kerberos locator plugin

Dmitri Pal dpal at redhat.com
Fri Mar 5 17:00:41 UTC 2010


Sumit Bose wrote:
> Hi,
>
> the following two patches are related to the Kerberos locator plugin.
>
> The first patch removes the name resolution from the locator plugin and
> let it use the IP address found by the resolver code. This way we can be
> sure to always talk to the same server until the resolver chooses a new
> server.
>
> The second patch tries to make debugging of the locator plugin easier by
> activating it automatically if the debug level of the Kerberos provider
> is 5 or higher. Also the timestamp and debug-to-files flags are
> respected.
>
> bye,
> Sumit
>   
I had a very quick glance.
I think you are missing checks after strdup().

ctx->kdc_addr = strdup((char *) buf);


I am not familiar with the code so it is hard for me to comment on anything else.




> ------------------------------------------------------------------------
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel


-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list