[SSSD] [PATCH] change alignment safe macros

Jakub Hrozek jhrozek at redhat.com
Tue Mar 2 15:25:02 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/01/2010 10:49 PM, Simo Sorce wrote:
> The main reason for this patch is to allow George to use them also
> where we don't actually need to increase a counter (just set the
> pointer to the counter to NULL).
> 
> I also decided to change the naming of both the macros and their
> variables to make them, hopefully, more clearear.
> 
> The "safealign" prefix in particular should hint the causal reader
> about the reason we use them instead of a using normal cast like we
> were doing before.
> 
> Simo.

I like the improvements and functionally, this would be an Ack.

However, I'm having problems with applying the patch. The ">From $SHA"
seems to be culprit, when changed to "From $SHA", the patch applied (and
worked fine).

	Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkuNLc4ACgkQHsardTLnvCX3mACgz6dpTovn7DxMXGETbPgcxxXL
FMwAoM2bNeKwPhdNiiK/wbJBZ+W2cPza
=Ax7u
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list